Difference: Amc13CppProductionSoftwareToDoList (3 vs. 4)

Revision 416 Jun 2014 - DavidZou

Line: 1 to 1
 
META TOPICPARENT name="AMC13CppProductionSoftware"
Added:
>
>
2014-06-13, hazen, dzou: I think you have left out parts of the register names in many cases. For example, below you want I believe "CONF.EVB.ENABLE_DAQLSC".

void AMC13::daqLinkEnable(bool b) { if(b) write(T1, "EVB.ENABLE_DAQLSC", 1); else write(T1, "EVB.ENABLE_DAQLSC", 0); }

This is a small thing, but I'd suggest the more concise:

void AMC13::daqLinkEnable(bool b) { write(T1, "EVB.ENABLE_DAQLSC", b); }

Please change the AMCInputEnable to take a bit mask instead of a list.

Please add an SFPOutputEnable to enable SFPs, taking a 3-bit mask (writes to CONF.SFP.ENABLE_MASK).

 2014-06-10, dzou:

A number of control functions implemented with hard coded addresses (due to no equivalent register).

 
This site is powered by the TWiki collaboration platform Powered by PerlCopyright © 2008-2019 by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding TWiki? Send feedback